[U-Boot] drivers/net/enc28j60.c - generalisation, how?

Reinhard Meyer reinhard.meyer at emk-elektronik.de
Mon Jul 26 02:07:31 CEST 2010


Ben Warren wrote:
> Hi Reinhard,
>
> On Sun, Jul 25, 2010 at 1:06 PM, Reinhard Meyer <
> reinhard.meyer at emk-elektronik.de> wrote:
>
>   
>> Mike Frysinger wrote:
>>     
>>> On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote:
>>>
>>>       
>>>> I would like to generalize that driver and make it also
>>>> CONFIG_NET_MULTI-able.
>>>>
>>>>         
>>> someone already has ... look at the archives in december of 09
>>>
>>>       
>> Thanks for the hint Mike,
>> it seems the thread there has died, and the work left incomplete however.
>> But it gives a head start to complete it.
>> The main issue I had is already proposed in that thread: rename the old
>> driver and make a new one :)
>>
>>     
> Then that seems like the right approach.  Create the new driver, port the
> existing boards to use it and see if anybody cares.  If somebody responds,
> you've found a tester.  If not, there may be some boards in the tree that
> compile fine but don't run.  Not a problem I'd lose much sleep over.
>   
Hello Ben,
I can rename the current driver to like "enc28j60_lpc2292.c" and make the
two affected boards use it, so they still compile and work. I can't do 
those boards' maintainers work and add the required code to use the new 
driver and make a generic spi framework for the lpc2292. They currently 
use a very private spi approach.
Or I call the new driver something like "enc28j60_generic.c".
I am definitely not going to port the existing two lpc2292 boards to use 
the new enc28j60 driver.
Reinhard


More information about the U-Boot mailing list