[U-Boot] omap3 dram_init not calling get_sdr_cs_size() for second bank

Michael Grundy michael.grundy at buglabs.net
Tue Jul 27 22:12:44 CEST 2010


Hi -

Our board's mtype is DDR_DISCRETE, the current dram_init will only call
get_sdr_cs_size for DDR_COMBO and DDR_STACKED.
An older version had the CS0 and CS1 calls consecutively. I'm not sure if
something else should be checked prior to the get_sdr_cs_size(CS1) or put
the call somewhere after make_cs1_contiguous as in the patch below. Any
thoughts on the proper way to do this?

Thanks!
Mike

diff --git a/arch/arm/cpu/armv7/omap3/sdrc.c
b/arch/arm/cpu/armv7/omap3/sdrc.c
index 96fd990..7686e1a 100644
--- a/arch/arm/cpu/armv7/omap3/sdrc.c
+++ b/arch/arm/cpu/armv7/omap3/sdrc.c
@@ -178,10 +178,10 @@ int dram_init(void)
        if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype == DDR_STACKED))
{
                do_sdrc_init(CS1, NOT_EARLY);
                make_cs1_contiguous();
-
-               size1 = get_sdr_cs_size(CS1);
        }

+       size1 = get_sdr_cs_size(CS1);
+
        gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
        gd->bd->bi_dram[0].size = size0;
        gd->bd->bi_dram[1].start = PHYS_SDRAM_1 + get_sdr_cs_offset(CS1);


More information about the U-Boot mailing list