[U-Boot] [PATCH v2] da830: Move common code out of da830evm.c file

Wolfgang Denk wd at denx.de
Tue Jun 1 12:01:39 CEST 2010


Dear Sudhakar Rajashekhara,

In message <1275383152-31122-1-git-send-email-sudhakar.raj at ti.com> you wrote:
> TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137
> in many aspects. So instead of repeating the same code in
> multiple files, move the common code to a different file
> and call those functions from the respective da830/da850
> files.
> 
> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj at ti.com>
> Acked-by: Nick Thompson <nick.thompson at ge.com>
> Acked-by: Ben Gardiner <bengardiner at nanometrics.ca>
> ---
> Since v1:
> Added irq_init declaration in misc.h to avoid compiler warning.

This patch causes the following compiler warning for me:

-> ./MAKEALL da830evm da850evm
Configuring for da830evm board...
da830evm.c:124: warning: missing braces around initializer
da830evm.c:124: warning: (near initialization for 'lpsc[0]')

122
123 static const struct lpsc_resource lpsc[] = {
124         DAVINCI_LPSC_AEMIF,     /* NAND, NOR */
125         DAVINCI_LPSC_SPI0,      /* Serial Flash */
126         DAVINCI_LPSC_EMAC,      /* image download */
127         DAVINCI_LPSC_UART2,     /* console */
128         DAVINCI_LPSC_GPIO,
129 };



Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
                                                   -- Francis Picabia


More information about the U-Boot mailing list