[U-Boot] [PATCH] ARM: remove unused ATAG

Wolfgang Denk wd at denx.de
Fri Jun 18 12:49:32 CEST 2010


Dear Minkyu Kang,

In message <4C1B4AEE.8090500 at samsung.com> you wrote:
> ATAG_VIDEOLFB is not used anywhere.

... not any more, that is.

> The belowing warning is occurred due to this ATAG.
> 
> [    0.000000] Ignoring unrecognised tag 0x54410008
> 
> This patch fixed it.

I think we should try to find another way to fix this.

> -    defined (CONFIG_VFD) || \
> -    defined (CONFIG_LCD)
> +    defined (CONFIG_REVISION_TAG)
>  static void setup_start_tag (bd_t *bd);
...
> -# if defined (CONFIG_VFD) || defined (CONFIG_LCD)
> -static void setup_videolfb_tag (gd_t *gd);
> -# endif
...
> -    defined (CONFIG_REVISION_TAG) || \
> -    defined (CONFIG_LCD) || \
> -    defined (CONFIG_VFD)
> +    defined (CONFIG_REVISION_TAG)
...
> -#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
> -	setup_videolfb_tag ((gd_t *) gd);
> -#endif
...

etc.

By removing all references to CONFIG_VFD you break support for the
board using this feature. As far as I know this board is stillrunnign
a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in
include/asm-arm/setup.h resp. arch/arm/kernel/setup.c

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.


More information about the U-Boot mailing list