[U-Boot] [PATCH] ARM: remove unused ATAG

[Martin Krause]

u-boot-bounces at lists.denx.de wrote on Friday, June 18, 2010 12:50 PM:
> Dear Minkyu Kang,
> 
> In message <4C1B4AEE.8090500 at samsung.com> you wrote:
>> ATAG_VIDEOLFB is not used anywhere.
> 
> ... not any more, that is.
> 
>> The belowing warning is occurred due to this ATAG.
>> 
>> [    0.000000] Ignoring unrecognised tag 0x54410008
>> 
>> This patch fixed it.
> 
> I think we should try to find another way to fix this.
> 
>> -    defined (CONFIG_VFD) || \
>> -    defined (CONFIG_LCD)
>> +    defined (CONFIG_REVISION_TAG)
>>  static void setup_start_tag (bd_t *bd);
> ...
>> -# if defined (CONFIG_VFD) || defined (CONFIG_LCD)
>> -static void setup_videolfb_tag (gd_t *gd);
>> -# endif
> ...
>> -    defined (CONFIG_REVISION_TAG) || \
>> -    defined (CONFIG_LCD) || \
>> -    defined (CONFIG_VFD)
>> +    defined (CONFIG_REVISION_TAG)
> ...
>> -#if defined (CONFIG_VFD) || defined (CONFIG_LCD)
>> -	setup_videolfb_tag ((gd_t *) gd);
>> -#endif
> ...
> 
> etc.
> 
> By removing all references to CONFIG_VFD you break support for the
> board using this feature. As far as I know this board is stillrunnign

If you reference to the trab board, then yes it is still running. But
on this board a very very old version of U-Boot is running, and I don't
see, that this would change during the remaining lifetime of the board.
Thus it's fine by me to break/remove the board support from current 
U-Boot.

> a 2.4.27-vrs1 kernel, which hdas ATAG_VIDEOLFB defined and used in
> include/asm-arm/setup.h resp. arch/arm/kernel/setup.c
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Martin Krause

Development
Phone +49 8153 9308-157, Fax +49 8153 9308-7157
mailto:martin.krause at tqs.de

TQ-Systems GmbH
Muehlstrasse 2, Gut Delling, D-82229 Seefeld, Germany
Amtsgericht München, HRB 105 018, UST-IdNr. DE 811 607 913
Place of business: Seefeld
Managing Directors: Dipl.-Ing. (FH) Detlef Schneider, Dipl.-Ing. (FH) Rüdiger Stahl
http://www.tq-group.com/