[U-Boot] [PATCH 2/3] add serial driver for pollux CPU

[Brian Cavagnolo]

On Tue, Jun 1, 2010 at 3:42 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Brian Cavagnolo,
>
> In message <1275417750-10020-2-git-send-email-brian at cozybit.com> you wrote:
>>
>> Signed-off-by: Brian Cavagnolo <brian at cozybit.com>
>> Signed-off-by: Andrey Yurovsky <yurovsky at gmail.com>
>> ---
>>  drivers/serial/Makefile        |    1 +
>>  drivers/serial/serial_pollux.c |  116 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 117 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/serial/serial_pollux.c
>
> Please see previous comments about using C structs with I/O accessors,
> coding style etc.

Understood.

> General question: do we really need a new UART driver, or can this be
> generalized with other drivers?

The s3c44b0 serial hardware is quite similar to that of the pollux.
There are some quirks (e.g., the pollux's registers are 16 bits and
the s3c44b0's are 32), but I think there are some reasonable ways to
address that.  I'll use that driver in v2.

Thanks,
Brian