[U-Boot] [PATCH 2/3] add serial driver for pollux CPU

[Wolfgang Denk]

Dear Brian Cavagnolo,

In message <1275417750-10020-2-git-send-email-brian at cozybit.com> you wrote:
> 
> Signed-off-by: Brian Cavagnolo <brian at cozybit.com>
> Signed-off-by: Andrey Yurovsky <yurovsky at gmail.com>
> ---
>  drivers/serial/Makefile        |    1 +
>  drivers/serial/serial_pollux.c |  116 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 117 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/serial/serial_pollux.c

Please see previous comments about using C structs with I/O accessors,
coding style etc.

General question: do we really need a new UART driver, or can this be
generalized with other drivers?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unix is simple, but it takes a genius to understand the simplicity."
					             - Dennis Ritchie