[U-Boot] GTH board status

[Wolfgang Denk]

Dear Thomas,

is the GTH board still actively being maintained, or what exactly is
it's state?

I'm trying to clean up a thing or two and ran into a few strange
things:

"common/env_common.c" has this:

230 #if defined(CONFIG_GTH) || defined(CONFIG_ENV_IS_NOWHERE)       /* Environment not changable */
231                 puts ("Using default environment\n\n");
232 #else
233                 puts ("*** Warning - bad CRC, using default environment\n\n");  
234                 show_boot_progress (-60);
235 #endif

This looks as if the GTH board had no persistent environment storage;
but when I was tempted to remove the "defined(CONFIG_GTH) ||" part
and add a "#define CONFIG_ENV_IS_NOWHERE" to "include/configs/GTH.h"
I see this:

197 #define CONFIG_ENV_IS_IN_FLASH 1
198 #undef CONFIG_ENV_IS_IN_EEPROM
199 #define CONFIG_ENV_OFFSET               0x000E0000
200 #define CONFIG_ENV_SIZE         0x4000  /* Total Size of Environment Sector     */
201
202 #define CONFIG_ENV_SECT_SIZE    0x50000 /* see README - env sector total size   */

That means that there is actually flash on the GTH board.

Do you agree that we simply remove the "defined(CONFIG_GTH) ||" part
from "common/env_common.c" ?


Then I noticed the CONFIG_ENV_SECT_SIZE = 0x50000 setting. I am sure
that your flash memory cannot have a sector size of 320 KiB - the
0x50000 must be bogus.

Please comment.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Use C++ to confuse your enemies; use C to produce stable code.