[U-Boot] [PATCH v2] ppc4xx: Add T3COPR board support (PPC460GT based)

[Stefan Roese]

Hi Wolfgang,

On Tuesday 29 June 2010 09:52:00 Wolfgang Denk wrote:
> > This patch adds support for the T3CORP board, based on the
> > AppliedMicro (AMCC) PPC460GT.
> 
> General question: should we rename "amcc" into "apm" ?

Personally, I don't like the idea to change all existing references from AMCC 
to APM. But you are right. Its better to use AppliedMicro or APM from now on. 
I'll switch to APM in the next patch version.
 
> ..
> 
> > +int board_early_init_r(void)
> > +{
> 
> ..
> 
> > +	/* Add TLB entry for 0xfn00.0000 -> 0x4.cn00.0000 */
> > +	program_tlb(CONFIG_SYS_FLASH_BASE_PHYS, CONFIG_SYS_FLASH_BASE,
> > +			CONFIG_SYS_FLASH_SIZE, TLB_WORD2_I_ENABLE);
> > +
> > +	/*
> > +	 * Now accessing of the whole 64Mbytes of NOR FLASH at virtual address
> > +	 * 0xfc00.0000 is possible
> > +	 */
> 
> What about the configuration with 128 MiB NOR flash?

Oops. This is a copy-n-paste error. There is no 128 MiB configuration for the 
T3CORP board. I'll fix the comment and the code in the next patch version.

> Would it not be
> more flexible to use something like
> 
> 	program_tlb(CONFIG_SYS_FLASH_END_PHYS-flash_info[0].size,
> 		-flash_info[0].size,
> 		flash_info[0].size, TLB_WORD2_I_ENABLE);
> 
> with
> 	CONFIG_SYS_FLASH_END_PHYS_H = 0x4
> and	CONFIG_SYS_FLASH_END_PHYS_L = 0xD0000000
> 
> ?

Not necessary with a fixed 64MiB board.
 
> BTW: Please use "flash" (globally) instead of FLASH - "flash" is not
> an abbreviation.

OK.
 
> > +int board_pcie_last(void)
> > +{
> > +	/*
> > +	 * Only PCIe0 for now, PCIe1 hangs on this boards
> 
> "on this board" or "on these boards"

OK. Thanks for the review.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de