[U-Boot] [PATCH] ARM1176: Coexist with other ARM1176 platforms

[Chemparathy, Cyril]

Hi Tom,

> This patch is premature.
> I need to see this patch within the context of the new SOC.
> 
> For a new SOC, I would like it be added as a new sub dir off of cpu/arm1176.
> At the same level as s3c64xx.  So this dir would look like.
> 
> config.mk  cpu.c  Makefile  new_soc_name s3c64xx  start.S  u-boot.lds

Correct.  The new SOC adds cpu/arm1176/tnetv107x/.

Would you prefer if I were to include this patch as part of the initial tnetv107x submission?  You could take a peek at this future submission at http://bit.ly/b1F2qX.

> The common code that is sharable should also be at this level.
> This may mean moving and generalizing some s3c64xx/*.c.

I have taken a look at the code inside s3c64xx, and found it specific to that SOC (memory interface initialization, reset, etc.).  Therefore, I don't think any of that code can be generalized and pulled out into cpu/arm1176/.  Guennadi, do you agree with this assessment?

> The SOC specific code must be in its own dir.  An example of this may be the
> lowlevel_init needs to move from start.S to <SOC>/lowlevel_init.S

lowlevel_init is _called_ from start.S and is expected to be implemented by SOCs if needed (ifndef CONFIG_SKIP_LOWLEVEL_INIT).

> I do not want one SOC if-def-ing up another SOC.

Absolutely.  I understand your concern, but this patch if-defs up arm1176 code, and not s3c64xx SOC code.

> The maintainer of the original s3c64xx SOC, Guennadi Liakhovetski
> <g.liakhovetski at gmx.de>, should be cc-ed on at least the initial changes so he
> has a heads up that some of his code is being moved/generalized.

Thanks.

Cyril.