[U-Boot] [PATCH] ARM1176: Coexist with other ARM1176 platforms

[Tom]

Chemparathy, Cyril wrote:
> Hi Tom,
> 
>> This patch is premature.
>> I need to see this patch within the context of the new SOC.
>>
>> For a new SOC, I would like it be added as a new sub dir off of cpu/arm1176.
>> At the same level as s3c64xx.  So this dir would look like.
>>
>> config.mk  cpu.c  Makefile  new_soc_name s3c64xx  start.S  u-boot.lds
> 
> Correct.  The new SOC adds cpu/arm1176/tnetv107x/.
> 
> Would you prefer if I were to include this patch as part of the initial tnetv107x submission?  You could take a peek at this future submission at http://bit.ly/b1F2qX.

I was not able to access this link
But, yes, please include this patch as part of the tnetv107x patchset.

> 
>> The common code that is sharable should also be at this level.
>> This may mean moving and generalizing some s3c64xx/*.c.
> 
> I have taken a look at the code inside s3c64xx, and found it specific to that SOC (memory interface initialization, reset, etc.).  Therefore, I don't think any of that code can be generalized and pulled out into cpu/arm1176/.  Guennadi, do you agree with this assessment?

Ok.
Obviously it is better to generalize than to make off-by-one copies
but not if there are not enough similarities to make it work..

> 
>> The SOC specific code must be in its own dir.  An example of this may be the
>> lowlevel_init needs to move from start.S to <SOC>/lowlevel_init.S
> 
> lowlevel_init is _called_ from start.S and is expected to be implemented by SOCs if needed (ifndef CONFIG_SKIP_LOWLEVEL_INIT).
> 
>> I do not want one SOC if-def-ing up another SOC.
> 
> Absolutely.  I understand your concern, but this patch if-defs up arm1176 code, and not s3c64xx SOC code.

My concern is that start.S, because it came originally from s3c64xx,
may need to either generalized or split up.  With s3c64xx parts moving to SOC
layer.  Assembly is complicated enough without having #if-def's and if can be
done in C it should.

Please review http://www.denx.de/wiki/U-Boot/Patches, clean up the patchset
and submit, having another arm1176 soc will be great.

Thanks
Tom