[U-Boot] [PATCH 1/3] arm: Add support for MB86R0x SoCs

[Wolfgang Denk]

Dear =?ISO-8859-1?Q?Matthias_Wei=DFer?=,

In message <4BD538D8.2040007 at arcor.de> you wrote:
>
>  > C struct, please.
...
>  > Ditto.
...
>  > Ditto.
> 
> Well, the above three modules are used in assembler code only 
> (lowlevel_init.S) and I didn't found a way to use C structs here. What 
> would be the right approach in this case? Defining all these registers
> as absolute addresses?

Mode these definitions (and only these) to a separate asm-offsets.h
header file, please.

Or, if you have the time, adapt the Linux code to auto-generate
asm-offsets.h from normal header files.

> I have a also a couple of magic values in the mentioned .S file. Do I 
> have to move them also to some symbolic constants?

Yes, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man is the best computer we can put aboard a spacecraft ...  and  the
only one that can be mass produced with unskilled labor.
                                                 -- Wernher von Braun