[U-Boot] [PATCH Repost] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

Prafulla Wadaskar prafulla at marvell.com
Fri May 21 07:07:09 CEST 2010


 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Mahavir Jain
> Sent: Wednesday, May 19, 2010 2:26 PM
> To: u-boot at lists.denx.de
> Cc: Mahavir Jain
> Subject: [U-Boot] [PATCH Repost] bugfix: Guruplug: Use 
> standard miiphy call to reset PHY chip.
> 
> Current PHY Software Reset operation in guruplug does not
> poll reset bit in control register to go to 0(auto clearing)
> for making sure reset was successful.This patch uses standard
> miiphy call miiphy_reset to make sure proper PHY reset operation.
> 
> Signed-off-by: Mahavir Jain <mjain at marvell.com>
> ---
>  board/Marvell/guruplug/guruplug.c |    9 +--------
>  1 files changed, 1 insertions(+), 8 deletions(-)
> 
> diff --git a/board/Marvell/guruplug/guruplug.c 
> b/board/Marvell/guruplug/guruplug.c
> index ba47ca1..c028a53 100644
> --- a/board/Marvell/guruplug/guruplug.c
> +++ b/board/Marvell/guruplug/guruplug.c
> @@ -146,14 +146,7 @@ void mv_phy_88e1121_init(char *name)
>  	miiphy_write(name, devadr, MV88E1121_PGADR_REG, 0);
>  
>  	/* reset the phy */
> -	if (miiphy_read (name, devadr, PHY_BMCR, &reg) != 0) {
> -		printf("Err..(%s) PHY status read failed\n", 
> __FUNCTION__);
> -		return;
> -	}
> -	if (miiphy_write (name, devadr, PHY_BMCR, reg | 0x8000) != 0) {
> -		printf("Err..(%s) PHY reset failed\n", __FUNCTION__);
> -		return;
> -	}
> +	miiphy_reset(name, devadr);
>  
>  	printf("88E1121 Initialized on %s\n", name);
>  }
> --

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .
 


More information about the U-Boot mailing list