[U-Boot] [PATCH 1/2] Add flexibility to mx51 video support

[Stefano Babic]

On 11/02/2010 06:15 AM, Frias Renato-B13784 wrote:
> This patch adds flexibility to mxc_ipuv3_fb.c by allowing the display
> interface and pixel format to be passed to mx51_fb_init.
> 
> Signed-off-by: Renato Frias <renato.frias at freescale.com>

Hi Renato,

you patch seems to be corrupted and does not apply. It seems your mailer
is responsible for this. It puts html code in the mail, too:

nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; pixfmt =3D =
IPU_PIX_FMT_RGB565;<BR>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;<BR>

Consider using git send-mail to post your patches to the list. This
avoid mail corruption.

> -       strcpy(fbi->fix.id, "DISP3 BG");
> +       if (ipu_di == 0)
> +               strcpy(fbi->fix.id, "DISP3 BG");
> +       else if (ipu_di == 1)
> +               strcpy(fbi->fix.id, "DISP3 BG - DI1");

I admit that I took the fix.id string from the linux driver, but it is
not used at all in the code. If we do not find a useful reason for it,
it should be probably better to get rid of it to avoid confusion.

> @@ -593,7 +596,7 @@ static int mxcfb_probe(u32 interface_pix_fmt, struct
> fb_videomode *mode)
>                 "XRES = %d YRES = %d BitsXpixel = %d\n",
>                 panel_info.vl_col,
>                 panel_info.vl_row,
> -               panel_info.vl_bpix);
> +               NBITS(panel_info.vl_bpix));

This is only a debug output to check the values in the panel_info
structure and prints them without doing any computation. If you want to
add the NBITS value (that in any case can be computed), please leave the
original output of vl_bpix, too.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================