[U-Boot] [PATCH 1/2] Add flexibility to mx51 video support

Renato Frias renato.frias at gmail.com
Wed Nov 3 01:12:09 CET 2010


Hello Stefano B,

On Tue, Nov 2, 2010 at 4:57 AM, Stefano Babic <sbabic at denx.de> wrote:

> you patch seems to be corrupted and does not apply. It seems your mailer
> is responsible for this. It puts html code in the mail, too:

Shame on me! I apologize for the mess, I configured Outlook for plain text.
I'll submit again...

> I admit that I took the fix.id string from the linux driver, but it is
> not used at all in the code. If we do not find a useful reason for it,
> it should be probably better to get rid of it to avoid confusion.

Agree! I can not see usage for this, will remove from the patch.

> This is only a debug output to check the values in the panel_info
> structure and prints them without doing any computation. If you want to
> add the NBITS value (that in any case can be computed), please leave the
> original output of vl_bpix, too.

Agree! I will remove from the patch.

Thanks,
Renato


More information about the U-Boot mailing list