[U-Boot] [PATCH v2 3/3] Fix video support for vision2 board

[Stefano Babic]

On 11/03/2010 04:02 AM, Renato Frias wrote:
> From: Renato Frias <renato.frias at freescale.com>
> 
> Adds arguments to the mx51_fb_init call.
> 
> Signed-off-by: Renato Frias <renato.frias at freescale.com>
> ---
> Changes for v2:
> 	- Includes fix to vision2 (this commit) on the patch set 
>  
> -	ret = mx51_fb_init(&nec_nl6448bc26_09c);
> +	ret = mx51_fb_init(&nec_nl6448bc26_09c, 0, 18);

I think there is aa misunderstanding at this point. You introduce a new
parameter (pix_fmt), that is used in the driver only to set up the
vl_bpix field of the panel_info structure.The field vl_bpixis the number
of bits x pixel that u-boot supports, in the range 1-4 (see defines
LCD_COLOR* in lcd.h), as we can display in u-boot bitmaps up to 16
colors. The same apply for the previous patch for mx51evk.

The first question I have is if we really need this parameter. In the
driver (bpp_to_pixfmt function) we do not support really less than 16
colors, so setting always panel_info.vl_bpix to LCD_COLOR16 seems to me
correct.

And the driver itself does not use internally this parameter and instead
of it takes interface_pix_fmt to set up the IPU.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================