[U-Boot] [PATCH] omap4: board: change global data pointer to file scope

Menon, Nishanth nm at ti.com
Thu Nov 4 16:58:10 CET 2010


On Mon, Oct 25, 2010 at 16:13, Menon, Nishanth <nm at ti.com> wrote:
> DECLARE_GLOBAL_DATA_PTR is currently defined within the scope
> of function while it is a global pointer. Change the scope of
> definition to replicate it's global scope. This seems to help
> gcc 4.5 optimizations as well.
>
> Signed-off-by: Nishanth Menon <nm at ti.com>

gentle ping - I dont see comments on this, is it ok to pull this in?

> ---
>  arch/arm/cpu/armv7/omap4/board.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap4/board.c
> b/arch/arm/cpu/armv7/omap4/board.c
> index 24a66f5..f967d09 100644
> --- a/arch/arm/cpu/armv7/omap4/board.c
> +++ b/arch/arm/cpu/armv7/omap4/board.c
> @@ -32,6 +32,8 @@
>  #include <asm/arch/sys_proto.h>
>  #include <asm/sizes.h>
>
> +DECLARE_GLOBAL_DATA_PTR;
> +
>  /*
>  * Routine: s_init
>  * Description: Does early system init of muxing and clocks.
> @@ -100,7 +102,6 @@ u32 sdram_size(void)
>  */
>  int dram_init(void)
>  {
> -       DECLARE_GLOBAL_DATA_PTR;
>
>  #if defined(CONFIG_SYS_ARM_WITHOUT_RELOC)
>        gd->bd->bi_dram[0].start = 0x80000000;
> --
> 1.6.3.3
>
>


More information about the U-Boot mailing list