[U-Boot] [PATCH] omap4: board: change global data pointer to file scope

[Wolfgang Denk]

Dear "Menon, Nishanth",

In message <AANLkTi=HWBUi5=zcfumMA-eAY7AAqw10g73w_cEx8sM5 at mail.gmail.com> you wrote:
> On Mon, Oct 25, 2010 at 16:13, Menon, Nishanth <nm at ti.com> wrote:
> > DECLARE_GLOBAL_DATA_PTR is currently defined within the scope
> > of function while it is a global pointer. Change the scope of
> > definition to replicate it's global scope. This seems to help
> > gcc 4.5 optimizations as well.
> >
> > Signed-off-by: Nishanth Menon <nm at ti.com>
> 
> gentle ping - I dont see comments on this, is it ok to pull this in?

This is OK.

The use of DECLARE_GLOBAL_DATA_PTR at function scope (instead file
scope) is known to cause incorrect code in some compiler /
architecture versions. We consider it a bug.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you want strict real-time behavior, run in the real  time  schedu-
ling class.  But there are no seatbelts or airbags;  main(){for(;;);}
can hard hang your system.                          -- Bart Smaalders