[U-Boot] [PATCH] fsl_pci_init: Make fsl_pci_init_port() PCI/PCIe aware

Peter Tyser ptyser at xes-inc.com
Sun Nov 14 16:01:38 CET 2010


On Sat, 2010-11-13 at 23:53 +0100, Wolfgang Denk wrote:
> Dear Kumar,
> 
> In message <1288297499-21417-1-git-send-email-ptyser at xes-inc.com> Peter Tyser wrote:
> > Previously fsl_pci_init_port() always assumed that a port was a PCIe
> > port and would incorrectly print messages for a PCI port such as the
> > following on bootup:
> >     PCI1:  32 bit, 33 MHz, sync, host, arbiter
> >                 Scanning PCI bus 00
> >     PCIE1 on bus 00 - 00
> > 
> > This change corrects the output of fsl_pci_init_port():
> >     PCI1:  32 bit, 33 MHz, sync, host, arbiter
> >                 Scanning PCI bus 00
> >     PCI1 on bus 00 - 00
> > 
> > Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> > ---
> > Tested on a MPC8548 with PCI, and a MPC8640 with PCIe
> > 
> >  drivers/pci/fsl_pci_init.c |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> I thought this should go through your tree, as it affects all the FSL
> boards.  Or are you waiting for me to pull this in?
> 
> 
> Also, there is still this other unresolved issue about indentation of
> the PCI messages.  Would you agree to clean this up as I suggested?

I submitted a 6-patch series starting with "fsl: Clean up printing of
PCI boot info" a while back which should address the indentation issue.
Ideally the fist 3 patches in that series would make it into the
upcoming release.  The last 3 are RFCs and could go in this release, or
the next.

Best,
Peter





More information about the U-Boot mailing list