[U-Boot] [PATCH/RFC 5/6] pci: Fix ordering of devices when CONFIG_PCI_SCAN_SHOW
Wolfgang Denk
wd at denx.de
Sun Nov 14 23:48:47 CET 2010
Dear Peter Tyser,
In message <1288393169-9814-5-git-send-email-ptyser at xes-inc.com> you wrote:
> Move the printing of PCI device information to before the PCI device is
> configured. This prevents the case where recursive scanning results in
> the deepest devices being printed first.
>
> This change also makes PCI lockups during enumeration easier to
> diagnose since the device that is being configured is printed out prior
> to configuration. Previously, it was not possible to determine which
> device caused the PCI lockup.
>
> Original example:
> PCIE1: connected as Root Complex
> 04:01.0 - 8086:1010 - Network controller
> 04:01.1 - 8086:1010 - Network controller
> 03:00.0 - 10b5:8112 - Bridge device
> 02:01.0 - 10b5:8518 - Bridge device
> 02:02.0 - 10b5:8518 - Bridge device
> 08:00.0 - 1957:0040 - Processor
> 07:00.0 - 10b5:8518 - Bridge device
> 09:00.0 - 10b5:8112 - Bridge device
> 07:01.0 - 10b5:8518 - Bridge device
> 07:02.0 - 10b5:8518 - Bridge device
> 06:00.0 - 10b5:8518 - Bridge device
> 02:03.0 - 10b5:8518 - Bridge device
> 01:00.0 - 10b5:8518 - Bridge device
> PCIE1: Bus 00 - 0b
>
> Updated example:
> PCIE1: connected as Root Complex
> 01:00.0 - 10b5:8518 - Bridge device
> 02:01.0 - 10b5:8518 - Bridge device
> 03:00.0 - 10b5:8112 - Bridge device
> 04:01.0 - 8086:1010 - Network controller
> 04:01.1 - 8086:1010 - Network controller
> 02:02.0 - 10b5:8518 - Bridge device
> 02:03.0 - 10b5:8518 - Bridge device
> 06:00.0 - 10b5:8518 - Bridge device
> 07:00.0 - 10b5:8518 - Bridge device
> 08:00.0 - 1957:0040 - Processor
> 07:01.0 - 10b5:8518 - Bridge device
> 09:00.0 - 10b5:8112 - Bridge device
> 07:02.0 - 10b5:8518 - Bridge device
> PCIE1: Bus 00 - 0b
>
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> ---
> drivers/pci/pci.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real computer scientists don't comment their code. The identifiers
are so long they can't afford the disk space.
More information about the U-Boot
mailing list