[U-Boot] [PATCH v3] hwconfig: Fix dummy initialization of {board, cpu}_hwconfig

Wolfgang Denk wd at denx.de
Tue Nov 30 22:11:22 CET 2010


Dear Kumar Gala,

In message <1291150888-20937-1-git-send-email-galak at kernel.crashing.org> you wrote:
> Since board_hwconfig & cpu_hwconfig are defined as weak and dont have a
> default value they will get put into the BSS if they aren't defined
> elsewhere.  This is problematic as we try to utilize hwconfig before
> we've relocated and thus BSS isn't setup.
> 
> Instead of giving dummy values in the board files that utilize this
> feature, we can just initialize the variables to an empty string and
> thus move them out of the BSS if they aren't defined elsewhere.
> 
> Also made board_hwconfig & cpu_hwconfig arrays to reduce size associated
> with string pointers vs arrays.
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
> * Removed null checks for board_hwconfig & cpu_hwconfig 
> 
>  board/freescale/mpc8641hpcn/mpc8641hpcn.c |    3 ---
>  board/freescale/p2020ds/p2020ds.c         |    3 ---
>  common/hwconfig.c                         |   14 ++++++--------
>  3 files changed, 6 insertions(+), 14 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You speak of courage. Obviously you do not know the  difference  bet-
ween  courage and foolhardiness. Always it is the brave ones who die,
the soldiers.
	-- Kor, the Klingon Commander, "Errand of Mercy",
	   stardate 3201.7


More information about the U-Boot mailing list