[U-Boot] AT91 clock and timer cleanups

Wolfgang Denk wd at denx.de
Mon Oct 4 19:00:10 CEST 2010


Dear Reinhard Meyer,

In message <4CA9EB88.5000203 at emk-elektronik.de> you wrote:
>
> 1. The board's config file defines "CONFIG_AT91FAMILY" like this:
> /* SoC */
> #define CONFIG_ARM926EJS	1	/* ARM926EJS Core	*/
> #define	CONFIG_AT91FAMILY	1	/* it's a member of AT91 */
> #define CONFIG_AT91SAM9260	1	/* Atmel AT91SAM9260 based SoC */
> #define CONFIG_AT91SAM9XE	1	/* more specific: AT91SAM9XE */

Out of principle: please omit the "1" in all such cases unless you
really want to pass or test for such a numeric value anywhere. As far
as I can tell all relevant code uses only "#ifdef" or "defined(...)",
so not to confuse people better omit the irrelevant value.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hiring experienced unix people is  like  a  built-in  filter  against
idiots. Hiring experienced NT people provides no such guarantee.
            -- Miguel Cruz in WgL96.349$CC.122704 at typhoon2.ba-dsg.net


More information about the U-Boot mailing list