[U-Boot] [PATCH V2] orion5x: optimize window size computation

Chris Moore moore at free.fr
Wed Oct 6 20:01:03 CEST 2010


  Hi,

Sorry Albert I missed this one last time :(

Le 06/10/2010 16:46, Albert Aribaud a écrit :
> + * 1) A sizeval equal to 0x0 specifies 4 TB

s/TB/GB/ or maybe even s/TB/GiB/

Question: are MB, GB, ... or MiB, GiB, ... preferred in U-Boot?

I generally try to use the "i" versions where appropriate.
In fact I used a KiB below:

> +	 * Calculate the number of 64 KiB blocks needed minus one (rounding up).

IMHO whatever the choice, it would be preferable to be consistent 
throughout.

Cheers,
Chris



More information about the U-Boot mailing list