[U-Boot] [PATCH V2] orion5x: optimize window size computation

Albert ARIBAUD albert.aribaud at free.fr
Wed Oct 6 20:35:12 CEST 2010


Le 06/10/2010 20:01, Chris Moore a écrit :
> Hi,
>
> Sorry Albert I missed this one last time :(
>
> Le 06/10/2010 16:46, Albert Aribaud a écrit :
>> + * 1) A sizeval equal to 0x0 specifies 4 TB
>
> s/TB/GB/ or maybe even s/TB/GiB/
>
> Question: are MB, GB, ... or MiB, GiB, ... preferred in U-Boot?

/me slaps himself.

One day, I'll get this one right the first time around, you'll see.

> I generally try to use the "i" versions where appropriate.
> In fact I used a KiB below:
>
>> + * Calculate the number of 64 KiB blocks needed minus one (rounding up).
>
> IMHO whatever the choice, it would be preferable to be consistent
> throughout.

Indeed, and as always, I prefer the les ambiguous choice: 4 TiB it is.

> Cheers,
> Chris

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list