[U-Boot] [PATCH] [NEW_RELOC] arm1136, qong: add support for ELF relocations

[Albert ARIBAUD]

Le 12/10/2010 13:31, Heiko Schocher a écrit :
> Signed-off-by: Wolfgang Denk<wd at denx.de>
> Signed-off-by: Heiko Schocher<hs at denx.de>
> ---

I assume this is [ELF_RELOC], not [NEW_RELOC], right? I'm asking because 
using the same tag for all "elf_reloc" branch related patches makes it 
easier to find them all back.

> diff --git a/arch/arm/cpu/arm1136/u-boot.lds b/arch/arm/cpu/arm1136/u-boot.lds

> +	__dynsym_start = .;
> +	.dynsym : { *(.dynsym) }
> +
>   	__got_start = .;
>   	. = ALIGN(4);
>   	.got : { *(.got) }

Do you need to keep .got in the linker file? I think it can be removed.

You could also add

	/DISCARD/ : { *(.dynstr*) }
	/DISCARD/ : { *(.dynamic*) }
	/DISCARD/ : { *(.plt*) }
	/DISCARD/ : { *(.interp*) }
	/DISCARD/ : { *(.gnu*) }

At the end of the sections statement.

> diff --git a/include/configs/qong.h b/include/configs/qong.h

> +#define	CONFIG_RELOC_FIXUP_WORKS

I believe this is now common to all ARMs, hence unneeded in config files.

Amicalement,
-- 
Albert.