[U-Boot] [PATCH] [NEW_RELOC] arm1136, qong: add support for ELF relocations

[Wolfgang Denk]

Dear Albert ARIBAUD,

In message <4CB478D4.3030702 at free.fr> you wrote:
> Le 12/10/2010 13:31, Heiko Schocher a écrit :
> > Signed-off-by: Wolfgang Denk<wd at denx.de>
> > Signed-off-by: Heiko Schocher<hs at denx.de>
> > ---
>
> I assume this is [ELF_RELOC], not [NEW_RELOC], right? I'm asking because
> using the same tag for all "elf_reloc" branch related patches makes it
> easier to find them all back.
>
> > diff --git a/arch/arm/cpu/arm1136/u-boot.lds b/arch/arm/cpu/arm1136/u-boot.lds
>
> > +	__dynsym_start = .;
> > +	.dynsym : { *(.dynsym) }
> > +
> >   	__got_start = .;
> >   	. = ALIGN(4);
> >   	.got : { *(.got) }
>
> Do you need to keep .got in the linker file? I think it can be removed.
>
> You could also add
>
> 	/DISCARD/ : { *(.dynstr*) }
> 	/DISCARD/ : { *(.dynamic*) }
> 	/DISCARD/ : { *(.plt*) }
> 	/DISCARD/ : { *(.interp*) }
> 	/DISCARD/ : { *(.gnu*) }
>
> At the end of the sections statement.

Agreed.

Heiko, can you please retest / resubmit?  Thanks.

> > diff --git a/include/configs/qong.h b/include/configs/qong.h
>
> > +#define	CONFIG_RELOC_FIXUP_WORKS
>
> I believe this is now common to all ARMs, hence unneeded in config files.

This should then be done for all board, i. e. in a separate commit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The day-to-day travails of the IBM programmer are so amusing to  most
of us who are fortunate enough never to have been one - like watching
Charlie Chaplin trying to cook a shoe.