[U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

Stefan Roese sr at denx.de
Tue Oct 12 17:41:48 CEST 2010


Hi Dirk,

On Tuesday 12 October 2010 15:33:07 Dirk Eibach wrote:
> Board support for the Guntermann & Drunck CATCenter Io.

Apart from Wolfgangs comments, some more from myself below.
 
> diff --git a/include/configs/io.h b/include/configs/io.h
> new file mode 100644
> index 0000000..53dce7d
> --- /dev/null
> +++ b/include/configs/io.h

<snip>

> +/* Gbit PHYs */
> +#define CONFIG_BITBANGMII		/* bit-bang MII PHY management	*/
> +
> +#define CONFIG_SYS_MDIO_PIN  (0x80000000 >> 13)	 /* our MDIO is GPIO0 
*/
> +#define CONFIG_SYS_MDC_PIN   (0x80000000 >> 7)	 /* our MDC  is GPIO7  
*/
> +
> +#define MDIO_ACTIVE	out32(GPIO0_TCR, in32(GPIO0_TCR) |
> CONFIG_SYS_MDIO_PIN)

Use out_be32() accessors here and below.

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list