[U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support

Eibach, Dirk Eibach at gdsys.de
Wed Oct 13 09:25:33 CEST 2010


> Hi Dirk,

Hi Stefan,

> ...
> <snip>
> 
> > +/* Gbit PHYs */
> > +#define CONFIG_BITBANGMII		/* bit-bang MII PHY 
> management	*/
> > +
> > +#define CONFIG_SYS_MDIO_PIN  (0x80000000 >> 13)	 /* our 
> MDIO is GPIO0 
> */
> > +#define CONFIG_SYS_MDC_PIN   (0x80000000 >> 7)	 /* our 
> MDC  is GPIO7  
> */
> > +
> > +#define MDIO_ACTIVE	out32(GPIO0_TCR, in32(GPIO0_TCR) |
> > CONFIG_SYS_MDIO_PIN)
> 
> Use out_be32() accessors here and below.

Just being curious: why? Has in32() also to be replaced?

> Please fix and resubmit. Thanks.

OK.
 
> Cheers,
> Stefan

Cheers
Dirk
--------------------------------------------------------------------------
Guntermann & Drunck GmbH Systementwicklung 
Dortmunder Str. 4a 
D-57234 Wilnsdorf - Germany 
Tel: +49 (0) 27 39 / 89 01 - 100  Fax: +49 (0) 27 39 / 89 01 - 120 
E-Mail: mailto:sales at gdsys.de Web: www.gdsys.de
--------------------------------------------------------------------------
Geschaeftsfuehrer: 
Udo Guntermann - Martin Drunck - Reiner Ruelmann - Klaus Tocke
HRB 2884, Amtsgericht Siegen - WEEE-Reg.-Nr. DE30763240
USt.-Id.-Nr. DE 126575222 - Steuer-Nr. 342 / 5835 / 1041
--------------------------------------------------------------------------
DQS-zertifiziert nach ISO 9001:2000
--------------------------------------------------------------------------




More information about the U-Boot mailing list