[U-Boot] [PATCH v2] Seagate FreeAgent DockStar support

[Wolfgang Denk]

Dear Eric Cooper,

In message <1287586475-18588-1-git-send-email-ecc at cmu.edu> you wrote:
...
> diff --git a/MAKEALL b/MAKEALL
> index c1f3842..83679b4 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -327,6 +327,7 @@ LIST_ARM9="			\
>  	cp966			\
>  	da830evm		\
>  	da850evm		\
> +	dockstar		\
>  	edb9301			\
>  	edb9302			\
>  	edb9302a		\

This is not needed any more for any boards registered in boards.cfg


> diff --git a/board/Marvell/dockstar/config.mk b/board/Marvell/dockstar/config.mk
> new file mode 100644
> index 0000000..761c2bb
> --- /dev/null
> +++ b/board/Marvell/dockstar/config.mk
> @@ -0,0 +1,28 @@
> +#
> +# (C) Copyright 2009
> +# Marvell Semiconductor <www.marvell.com>
> +# Written-by: Prafulla Wadaskar <prafulla at marvell.com>
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> +# MA 02110-1301 USA
> +#
> +
> +CONFIG_SYS_TEXT_BASE = 0x00600000

Please move this as #define into the board config file.

> +# Kirkwood Boot Image configuration file
> +KWD_CONFIG = $(SRCTREE)/board/$(BOARDDIR)/kwbimage.cfg

I would like to get rid of this, too. But this needs discussion with
Prafulla.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just because your doctor has a name for your condition  doesn't  mean
he knows what it is.