[U-Boot] [PATCH 3/3] tqm85xx: Update PCI code

[Peter Tyser]

On Tue, 2010-10-26 at 21:54 +0200, Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1285785448-4703-3-git-send-email-ptyser at xes-inc.com> you wrote:
> > Update to use the recent, common FSL PCI initialization code.
> > 
> > Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> > CC: sr at denx.de
> > ---
> >  board/tqc/tqm85xx/law.c     |    4 +-
> >  board/tqc/tqm85xx/tlb.c     |   10 ++--
> >  board/tqc/tqm85xx/tqm85xx.c |  151 ++++++++++++-------------------------------
> >  include/configs/TQM85xx.h   |   20 +++---
> >  4 files changed, 59 insertions(+), 126 deletions(-)
> 
> This commit needs fixing.
> 
> First, it corrupts the output. Some patch like this should be added:
> 
> diff --git a/board/tqc/tqm85xx/tqm85xx.c b/board/tqc/tqm85xx/tqm85xx.c
> index 2c3885f..027c429 100644
> --- a/board/tqc/tqm85xx/tqm85xx.c
> +++ b/board/tqc/tqm85xx/tqm85xx.c
> @@ -567,7 +567,7 @@ void pci_init_board (void)
>  	if (!(devdisr & MPC85xx_DEVDISR_PCI1)) {
>  		SET_STD_PCI_INFO(pci_info[num], 1);
>  		pcie_ep = fsl_setup_hose(&pci1_hose, pci_info[num].regs);
> -		printf ("\n   PCI1:  %d bit, %s MHz, %s, %s, %s\n",
> +		printf ("PCI1:  %d bit, %s MHz, %s, %s, %s\n",
>  			(pci_32) ? 32 : 64,
>  			(pci_speed == 33333333) ? "33" :
>  			(pci_speed == 66666666) ? "66" : "unknown",
> @@ -591,7 +591,7 @@ void pci_init_board (void)
>  		}
>  #endif
>  	} else {
> -		printf("    PCI1: disabled\n");
> +		printf("PCI1:  disabled\n");
>  	}
>  #else
>  	setbits_be32(&gur->devdisr, MPC85xx_DEVDISR_PCI1);
> 
> 
> Even worse, we now see a (badly formatted, but this is just an added
> "bonus")
> 
> 	Scanning PCI bus 00
>     PCIE1 on bus 00 - 00
> 
> which is completely bogus as there on these boards nor on these
> processors.
> 
> 
> Can you please provide a fix?

Can you send the entire bootup output?  The code is based on Freescale
reference boards, eg the mpc8568mds, so I'd guess the problem is not
tqm85xx-specific.

Best,
Pete