[U-Boot] [RFC 0/3] omap3evm: Add support for quick boot

Wolfgang Denk wd at denx.de
Thu Oct 28 18:54:18 CEST 2010


Dear Sanjeev Premi,

In message <1288283919-3837-1-git-send-email-premi at ti.com> you wrote:
> This series is based on the comments received [1] on
> my earlier submission[2].
> 
> Intent of sending as RFC is to thrash out the ideas
> and then send a formal patch.

Sorry, as you submitted this I see only 3 completely new files without
relation to each other nor with any relation to the existing code.

I suggest the following approach:

Patch 1: move common code out of include/configs/omap3_evm.h into a
	 new file include/configs/omap3_evm_common.h; this patch
	 should result in exactly the same code for the board as we
	 have now.

         Do not rename omap3_evm.h into omap3_evm_full.h; this makes
         no sense to me. omap3_evm.h is and remains the default
         configuration.

Patch 2: Create a new file omap3_evm_quick.h, which contains the
	 speed optimized configuration settings.  Get rid of all the 

	 	#ifndef FOO
		#define FOO
		#endif
	
	 stuff there. This is a plain simple and fixed configuration,
	 so this is not needed.

You may even consider to splitting this more - into
omap3_evm_quick_nand.h and omap3_evm_quick_mmc.h to eliminate even
more of the #ifdeffery.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A modem is a baudy house.


More information about the U-Boot mailing list