[U-Boot] [PATCH 08/11] mtd: nand: honor CONFIG_SYS_NAND_QUIET_TEST with unknown NAND printk

Scott Wood scottwood at freescale.com
Wed Sep 1 18:26:18 CEST 2010


On Tue, 31 Aug 2010 19:18:27 -0500
"Paulraj, Sandeep" <s-paulraj at ti.com> wrote:

> 
> 
> > 
> > This printk was added recently and results in ugly output on systems
> > with no NAND:
> > 
> > NAND:  nand_get_flash_type: unknown NAND device: Manufacturer ID: 0x00,
> > Chip ID: 0x00 0 MiB
> > 
> > instead of:
> > 
> > NAND:  0 MiB
[snip]
> >  	if (!type) {
> > +#ifndef CONFIG_SYS_NAND_QUIET_TEST
> >  		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID:"
> >  		       " 0x%02x, Chip ID: 0x%02x\n", __func__,
> >  		       *maf_id, dev_id);
> > +#endif
> >  		return ERR_PTR(-ENODEV);
> >  	}
> > 

Hmm, the current use of that seems to be suppressing warnings about
NAND that isn't present at all, not about NAND whose type we don't
recognize.

Perhaps we could instead suppress the warning only for probably-invalid
values such as 0x00 and 0xff, if that's how a missing NAND chip
manifests?

-Scott



More information about the U-Boot mailing list