[U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence

Albert ARIBAUD albert.aribaud at free.fr
Tue Sep 7 13:23:26 CEST 2010


Le 07/09/2010 08:42, Prafulla Wadaskar a écrit :
>> diff --git a/drivers/block/mvsata_ide.c b/drivers/block/mvsata_ide.c

>> @@ -125,15 +129,17 @@ int ide_preinit(void)

>> +		return 1;
>
> How about returning negative values for errors ?

Function ide_preinit() is called from cmd_ide.c:ide_init(), which does 
not distinguish positive vs negative return values, ony zero vs 
non-zero. So what would be the point of returning negative rather than 
positive values?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list