[U-Boot] ARM mach-types.h (was: Re: [PATCH 1/5] add DOCKSTAR machine type)

Wolfgang Denk wd at denx.de
Wed Sep 8 11:08:19 CEST 2010


Dear Reinhard Meyer,

In message <4C874C02.9030801 at emk-elektronik.de> you wrote:
>
> > I'm open to suggestions.
> 
> I'd allow manual adding of a #define MACH_TYPE_xxxx at the end of the list
> provided its value is higher than the last "official" entry. Once the official
> list reaches or goes beyond that value the manual line(s) would be removed.
> Not being a shell script guru, I think that could be easily done.

No. This will quicklly result in a maze of merge conflicts.

We will always only update the file as a whole.  THe only option I'm
willing to discuss is where to get the file from.

> One catch remains, of course: I someone changed their entry at the database,
> compilation of u-boot for that board could break. I think that entries that
> have propagated to the mainline Linux kernel cannot be changed anymore.

Right. Which is exactly the reason for syncing against this version.

> I'd also think the u-boot mach-type.h could do well without all the function
> definitions. I have not grepped, however, if someone in u-boot uses them.

I don;t think we do. But as mentioned above, we don;t want to mess
with this file, we just update it as is.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Perl script is correct if it's halfway readable and  gets  the  job
done before your boss fires you.
                       - L. Wall & R. L. Schwartz, _Programming Perl_


More information about the U-Boot mailing list