[U-Boot] ARM mach-types.h (was: Re: [PATCH 1/5] add DOCKSTAR machine type)

Reinhard Meyer u-boot at emk-elektronik.de
Wed Sep 8 11:33:57 CEST 2010


Wolfgang Denk schrieb:
> Dear Reinhard Meyer,
> 
> In message <4C874C02.9030801 at emk-elektronik.de> you wrote:
>>> I'm open to suggestions.
>> I'd allow manual adding of a #define MACH_TYPE_xxxx at the end of the list
>> provided its value is higher than the last "official" entry. Once the official
>> list reaches or goes beyond that value the manual line(s) would be removed.
>> Not being a shell script guru, I think that could be easily done.
> 
> No. This will quicklly result in a maze of merge conflicts.

Not sure about that. I was thinking of a simple script that reads Linux'
mach-types.h (or arch/arm/tools/mach-types directly) and generates the
u-boot's mach-types.h file on the fly. That way only the #define lines could
be generated, producing a less than 100k files instead of > 1MB.

The same script would read the existing mach-types.h file, scanning for
something like

/* MANUAL ENTRIES START */
#define MACH_TYPE_XYZ 4711
#define MACH_TYPE_ABC 4712
/* MANUAL ENTRIES END */

and retain lines that are still above the official limit.
A commit should show only "+" for the new official definitions and a "-"
for all automagically removed manual definitions.

Otherwise:

It essentially means one can send patches for a new ARM based board
only if the MACH_TYPE has trickled through all the instances.

This is, somehow, unpleasing:). We should not "punish" ourselves in u-boot
just because someone has invented a method to prolong time-to-market ;)

Reinhard



More information about the U-Boot mailing list