[U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

[Stefan Roese]

Hi Marri,

On Wednesday 08 September 2010 04:06:21 tmarri at apm.com wrote:
> From: Tirumala Marri <tmarri at apm.com>
> 
> APM821XX is a new line of SoCs which are derivatives of
> PPC44X family of processors. This patch adds support of CPU, cache,
> tlb, 32k ocm, bootstraps, PLB and AHB bus.

Look mostly good. One comment though below.
 
> Signed-off-by: Tirumala R Marri <tmarri at apm.com>
> ---
> V2:
>   * Removed Defines added to 405ex.
> V3:
>   * Change APM82XXX to APM821XX
>   * Modify the way cpu id is printed.
>   * Correct inadvertent change.
>   * Sort define list.
>   * Remove comment for get_sys_info().
>   * Define a symbolic constat ISRAM1_OCM_SIZE.
>   * Create apm821xx.h instead of using ppc440.h
>   * Correct multiline comment.
> ---
>  arch/powerpc/cpu/ppc4xx/cpu.c           |   36 ++-
>  arch/powerpc/cpu/ppc4xx/cpu_init.c      |    5 +-
>  arch/powerpc/cpu/ppc4xx/speed.c         |   76 +++++-
>  arch/powerpc/cpu/ppc4xx/start.S         |   11 +-
>  arch/powerpc/cpu/ppc4xx/tlb.c           |    2 +
>  arch/powerpc/include/asm/ppc4xx-ebc.h   |    4 +
>  arch/powerpc/include/asm/ppc4xx-isram.h |   14 +-
>  arch/powerpc/include/asm/ppc4xx-sdram.h |   12 +-
>  arch/powerpc/include/asm/ppc4xx-uic.h   |    5 +-
>  arch/powerpc/include/asm/processor.h    |    1 +
>  include/apm821xx.h                      |  493 +++++++++++++++++++++++++++++++

I know that Wolfgang specifically asked you to add this file for this
"new" SoC. But I'm not so sure if this is the right way. Most of the
defines in this new file are a plain copy from include/ppc440.h.

Wolfgang, do you really think this is better than adding support for
this SoC into ppc440.h? After all, the CPU core of this SoC is still
a PPC4xx PowerPC.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de