[U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

[Wolfgang Denk]

Dear Stefan Roese,

In message <201009091645.16076.sr at denx.de> you wrote:
>
> >  include/apm821xx.h                      |  493 +++++++++++++++++++++++++++++++
> 
> I know that Wolfgang specifically asked you to add this file for this
> "new" SoC. But I'm not so sure if this is the right way. Most of the
> defines in this new file are a plain copy from include/ppc440.h.
> 
> Wolfgang, do you really think this is better than adding support for
> this SoC into ppc440.h? After all, the CPU core of this SoC is still
> a PPC4xx PowerPC.

It makes no sense to duplicate common parts. Only different code
should be moved to separate files.

Viele Grüße,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When in doubt, mumble;   when in trouble, delegate;  when in  charge,
ponder.                                             -- James H. Boren