[U-Boot] [PATCH] ppc4xx: UART: Use NS16550 struct instead of offset macros

Stefan Roese sr at denx.de
Thu Sep 16 16:03:25 CEST 2010


Hi Wolfgang,

On Thursday 16 September 2010 14:27:23 Wolfgang Denk wrote:
> > Yes, I remember. I'm "on the way" to using this common driver. But the
> > PPC4xx one currently has quite a lot of special handling cases, like
> > this SOFTWARE_FIFO stuff, which I first need to sort out.
> 
> Are any of these special cases really needed / used anywhere in
> current code?

Yes, there is this CONFIG_CMD_KGDB (which I never used). From a quick glance 
this is also not used though. So this can be removed as well.

> > But again, I'll try to move to the common driver soon.
> 
> If you plan to move anyway, then why would you clean up the old (to be
> removed) driver first?  Just throw it out unchanged...

OK, you convinced me. I'll try to move directly without this "migration" step.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list