[U-Boot] [PATCH 1/2] Implementation of a auto-update hash-check- if image has new hash, update flash, otherwise boot device immediately

[Wolfgang Denk]

Dear Christoph Koenig,

In message <1301671320-16131-1-git-send-email-christoph.koenig at ikt.uni-hannover.de> you wrote:
> ---
>  common/image.c  |    2 +-
>  common/update.c |   42 +++++++++++++++++++++++++++++++++++-------
>  include/image.h |    3 +++
>  3 files changed, 39 insertions(+), 8 deletions(-)

Please use a short subject line, and provide a proper commit message.

Your SoB line is missing.

> -static int update_load(char *filename, ulong msec_max, int cnt_max, ulong addr)
> +static int update_load(char *filename, ulong msec_max, int cnt_max, ulong addr, int *size)

Line too long. Please fix globally.

> +	if (calculate_hash((void *)addr, size, algo, &value, &value_len)) {
> +		printf(" Error: Error during hash calculation\n");
> +		return 1;

No spaces at the beginning of the line. "Error" is redundant here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No one wants war.
	-- Kirk, "Errand of Mercy", stardate 3201.7