[U-Boot] [PATCH] USB: Remove __attribute__ ((packed)) for struct ehci_hccr and ehci_hcor.

Wolfgang Denk wd at denx.de
Sat Apr 2 00:53:28 CEST 2011


Dear Alexander Holler,

In message <1301697344-4033-1-git-send-email-holler at ahsoftware.de> you wrote:
> Remove __attribute__ ((packed)) to prevent byte access to soc
> registers in some gcc versions.
> 
> Having patches to enable ehci for the BeagleBoard lying around for
> several month, this one was the show-stopper.
> 
> Credits have to go to Laine Walker-Avina <lwalkera at ieee.org> for
> finding the problem.
> 
> Signed-off-by: Alexander Holler <holler at ahsoftware.de>
> ---
>  drivers/usb/host/ehci.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Can you PLEASE start playing by the rules?

This applies to you as well:
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Why do you repost this stuff without any comments, versioning or
changelog?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Crash programs fail because they are based on the theory  that,  with
nine women pregnant, you can get a baby a month.  - Wernher von Braun


More information about the U-Boot mailing list