[U-Boot] [PATCH V6 2/5] mv_i2c: use structure to replace the direclty define

[Wolfgang Denk]

Dear Lei Wen,

In message <BANLkTinqDkchrug8GAo2U6LMA0mKrfdb2Q at mail.gmail.com> you wrote:
> 
> >> @@ -114,13 +97,15 @@ static void i2c_reset(void)
> >>  static int i2c_isr_set_cleared(unsigned long set_mask,
> >>                              unsigned long>  cleared_mask)
> >>  {
> >> -     int timeout = 10000;
> >> +     int timeout = 1000, isr;
> >
> > Is this done purposely? Or reducing timeout value from 10000 to 1000 has > some meaning?
>
> You may notice original comment above this function is timeout if (no
> match within 10 ms).
> So the 10ms is 1000*10us, not the 10000*10us. In this patch I correct
> this to match its comments.

Please split this fix (and all similar changes) out into separate
patches, explain what you are doing and why in the commit messages,
and submit separately.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How do you play religious roulette?
A:  You stand around in a circle  and  blaspheme  and  see  who  gets
    struck by lightning first.