[U-Boot] [PATCH V7 2/5] mv_i2c: use structure to replace the direclty define

Wolfgang Denk wd at denx.de
Sun Apr 3 15:27:44 CEST 2011


Dear Lei Wen,

In message <1301835656-20512-3-git-send-email-leiwen at marvell.com> you wrote:
> Add i2c_clk_enable in the cpu specific code, since previous platform it,
> while new platform don't need. In the pantheon and armada100 platform,
> this function is defined as NULL one.
> 
> Signed-off-by: Lei Wen <leiwen at marvell.com>
...
> @@ -114,13 +97,15 @@ static void i2c_reset(void)
>  static int i2c_isr_set_cleared(unsigned long set_mask,
>  			       unsigned long cleared_mask)
>  {
> -	int timeout = 10000;
> +	int timeout = 1000, isr;

As mentioned before: such fixes must be split off into separate
patches and suent independent from this patch series.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
                                                   -- Francis Picabia


More information about the U-Boot mailing list