[U-Boot] [PATCHv2 3/4] I2C: add driver of st-ericsson u8500 i2c

[Heiko Schocher]

Hello John,

John Rigby wrote:
> From: Michael Brandt <michael.brandt at stericsson.com>
> 
> Signed-off-by: John Rigby <john.rigby at linaro.org>
> CC: Heiko Schocher <hs at denx.de>
> ---
> v2: Incorporate suggestions from Heiko Schocher

Thanks, one nitpicking comment...

> 
>  drivers/i2c/Makefile    |    1 +
>  drivers/i2c/u8500_i2c.c |  613 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/i2c/u8500_i2c.h |  194 +++++++++++++++
>  3 files changed, 808 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/u8500_i2c.c
>  create mode 100644 drivers/i2c/u8500_i2c.h
> 
[...]
> diff --git a/drivers/i2c/u8500_i2c.h b/drivers/i2c/u8500_i2c.h
> new file mode 100644
> index 0000000..881dcc5
> --- /dev/null
> +++ b/drivers/i2c/u8500_i2c.h
[...]
> +/* Mask values for Interrupt registers */
> +#define U8500_I2C_INT_TXFE	0x00000001	/* Tx fifo empty */
> +#define U8500_I2C_INT_TXFNE	0x00000002	/* Tx Fifo nearly empty */
> +#define U8500_I2C_INT_TXFF	0x00000004	/* Tx Fifo Full */
> +#define U8500_I2C_INT_TXFOVR	0x00000008	/* Tx Fifo over run */
> +#define U8500_I2C_INT_RXFE	0x00000010	/* Rx Fifo Empty */
> +#define U8500_I2C_INT_RXFNF	0x00000020	/* Rx Fifo nearly empty */
> +#define U8500_I2C_INT_RXFF	0x00000040	/* Rx Fifo Full  */
> +#define U8500_I2C_INT_RFSR	0x00010000	/* Read From slave request */
> +#define U8500_I2C_INT_RFSE	0x00020000	/* Read from slave empty */
> +#define U8500_I2C_INT_WTSR	0x00040000	/* Write to Slave request */
> +#define U8500_I2C_INT_MTD	0x00080000	/* Master Transcation Done*/
> +#define U8500_I2C_INT_STD	0x00100000	/* Slave Transaction Done */
> +#define U8500_I2C_INT_MAL	0x01000000	/* Master Arbitation Lost */
> +#define U8500_I2C_INT_BERR	0x02000000	/* Bus Error */
> +#define U8500_I2C_INT_MTDWS	0x10000000	/* Master Transaction Done wo/ Stop */

Line over 80 characters.

[...]

Beside of that, it looks Ok to me.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany