[U-Boot] [PATCH] nand/spl: Assuming a static nand page size to reduce code size

Scott Wood scottwood at freescale.com
Tue Apr 5 21:03:50 CEST 2011


On Tue, 5 Apr 2011 14:00:23 -0500
McClintock Matthew-B29882 <B29882 at freescale.com> wrote:

> On Tue, Apr 5, 2011 at 1:48 PM, Scott Wood <scottwood at freescale.com> wrote:
> > When building for MPC8315ERDB_NAND, I get:
> >
> > nand_boot_fsl_elbc.c: In function 'nand_load':
> > nand_boot_fsl_elbc.c:54:20: error: 'CONFIG_NAND_OR_PRELIM' undeclared (first use in this function)
> > nand_boot_fsl_elbc.c:54:20: note: each undeclared identifier is reported only once for each function it appears in
> >
> > It appears 85xx calls it CONFIG_NAND_OR_PRELIM, and 83xx calls it
> > CONFIG_SYS_NAND_OR_PRELIM.  The latter seems like what we should be
> > using.
> >
> > I can't figure out what's "prelim" about it either, but that's another
> > matter.  :-)
> 
> I'll submit a follow up patch renaming CONFIG_NAND_OR_PRELIM to
> CONFIG_SYS_NAND_OR_PRELIM and CONFIG_NAND_BR_PRELIM to
> CONFIG_SYS_NAND_BR_PRELIM? Should I go ahead and drop the PRELIM as
> well?

Just add the SYS, dropping PRELIM everywhere would be a bigger rename and
should be done separately if we decide to do that.

-Scott



More information about the U-Boot mailing list