[U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec

[Mike Frysinger]

On Tuesday, April 05, 2011 17:59:53 Andy Fleming wrote:
> --- a/include/phy.h
> +++ b/include/phy.h
> +int atheros_init(void);
> +int broadcom_init(void);
> +int davicom_init(void);
> +int lxt_init(void);
> +int marvell_init(void);
> +int micrel_init(void);
> +int natsemi_init(void);
> +int realtek_init(void);
> +int teranetics_init(void);
> +int vitesse_init(void);

imo, these should have a "phy_" prefix on their names.  these are pretty 
generic otherwise.

> diff --git a/include/phylib_all_drivers.h b/include/phylib_all_drivers.h

this probably should be prefixed with a "config_" to match the existing header 
filename style.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110406/d39a2262/attachment.pgp