[U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

Wolfgang Denk wd at denx.de
Thu Apr 7 06:43:44 CEST 2011


Dear Andy Fleming,

In message <1302040794-19837-5-git-send-email-afleming at freescale.com> you wrote:
> Extends the mii_dev structure to participate in a full-blown MDIO and
> PHY driver scheme.  The mii_dev structure and miiphy calls are modified
> in such a way to allow the original mii command and miiphy
> infrastructure to work as before, but also to support a new set of APIs
> which allow (among other things) sharing of PHY driver code and 10G support
...
> +#define SUPPORTED_10baseT_Half		(1 << 0)
> +#define SUPPORTED_10baseT_Full		(1 << 1)
> +#define SUPPORTED_100baseT_Half		(1 << 2)
> +#define SUPPORTED_100baseT_Full		(1 << 3)
> +#define SUPPORTED_1000baseT_Half	(1 << 4)
> +#define SUPPORTED_1000baseT_Full	(1 << 5)
> +#define SUPPORTED_Autoneg		(1 << 6)
> +#define SUPPORTED_TP			(1 << 7)
> +#define SUPPORTED_AUI			(1 << 8)
> +#define SUPPORTED_MII			(1 << 9)
> +#define SUPPORTED_FIBRE			(1 << 10)
> +#define SUPPORTED_BNC			(1 << 11)
> +#define SUPPORTED_10000baseT_Full	(1 << 12)
> +#define SUPPORTED_Pause			(1 << 13)
> +#define SUPPORTED_Asym_Pause		(1 << 14)
> +#define SUPPORTED_2500baseX_Full	(1 << 15)
> +#define SUPPORTED_Backplane		(1 << 16)
> +#define SUPPORTED_1000baseKX_Full	(1 << 17)
> +#define SUPPORTED_10000baseKX4_Full	(1 << 18)
> +#define SUPPORTED_10000baseKR_Full	(1 << 19)
> +#define SUPPORTED_10000baseR_FEC	(1 << 20)

We don't allow for CamelCaps identifiers or macro names. Macros are
all caps, please.  Please fix globally.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Of all the things I've lost, I miss my mind the most.


More information about the U-Boot mailing list