[U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure

[Andy Fleming]

On Apr 6, 2011, at 7:07 AM, Detlev Zundel wrote:

> Hi Andy,
> 
>> This second version cleans up all checkpatch errors that I reasonably could,
>> and addresses most of the comments from the first round of reviews.
> 
>  WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
>  #1299: FILE: drivers/net/tsec.c:1740:
>  +static int tsec_send(struct eth_device *dev, volatile void *packet, int length)
> 
> Ah I see.  This is needed because include/net.h prescribes this as the
> interface.  Oh well, we should clean this up at some later point, so
> it's ok from my perspective to ignore this and at least stay consistent.
> 
>  WARNING: do not add new typedefs
>  #4271: FILE: include/phy.h:389:
>  +typedef enum {
> 
> I know that we have lots of typedefs, but we should not add new ones.
> Actually not using this typedef for an enum-type would make the sources
> easier for me to read as I don't have to do this extra lookup step.


True, but this typedef is in Linux the same way. It seemed sensible to keep them the same


> 
>  WARNING: do not add new typedefs
>  #6304: FILE: arch/powerpc/include/asm/fsl_enet.h:31:
>  +typedef struct tsec_mii_mng {
> 
> I'd also appreciate if you use "struct tsec_mii_mng" explicitely instead
> of adding another typedef.


Yeah, you're right.  I'll eliminate this one.

Andy