[U-Boot] [PATCH] Handle most LDSCRIPT setting centrally

Graeme Russ graeme.russ at gmail.com
Fri Apr 8 08:07:40 CEST 2011


On 08/04/11 02:01, Scott Wood wrote:
> On Thu, 7 Apr 2011 09:11:03 +0200
> Wolfgang Denk <wd at denx.de> wrote:
> 
>> Dear Scott Wood,
>>
>> In message <20110406233136.GA13709 at schlenkerla.am.freescale.net> you wrote:
>>> Currently, some linker scripts are found by common code in config.mk.
>>> Some are found using CONFIG_SYS_LDSCRIPT, but the code for that is
>>> sometimes in arch config.mk and sometimes in board config.mk.  Some
>>> are found using an arch-specific rule for looking in CPUDIR, etc.
>>>
>>> Further, the powerpc config.mk rule relied on CONFIG_NAND_SPL
>>> when it really wanted CONFIG_NAND_U_BOOT -- which covered up the fact
>>> that not all NAND_U_BOOT builds actually wanted CPUDIR/u-boot-nand.lds.
>>>
>>> Replace all of this -- except for a handful of boards that are actually
>>> selecting a linker script in a unique way -- with centralized ldscript
>>> finding.
>>
>> Thanks for this nice cleanup.
>>
>> Only one question: Which boards / architectures did you cover during
>> your tests?
> 
> As I noted, I did a MAKEALL ppc and all the output (sizes, errors, etc) was
> the same as before the patch.
> 
> I tried a few arm boards, and all the ones I tried failed the same way they
> did before the patch.  I don't have toolchains for the other arches
> readily available.  Any help in testing this change on non-ppc would be
> appreciated.
> 

I have tried this patch on all (two!) x86 configurations and looks good

You may have my:

Tested-by: Graeme Russ <graeme.russ at gmail.com>

Regards,

Graeme


More information about the U-Boot mailing list