[U-Boot] [PATCH v2 2/2] avr32: fixup definitions to ATMEL_BASE_xxx

Reinhard Meyer u-boot at emk-elektronik.de
Mon Apr 11 10:58:47 CEST 2011


Dear Andreas Bießmann:
> Signed-off-by: Andreas Bießmann <biessmann at corscience.de>
> ---
> changes since v1:
>  - only rename definitions to ATMEL_BASE_xx schema in this patch
>  - rename of memeory-map.h -> hardweare.h is required before
> 
>  arch/avr32/cpu/at32ap700x/sm.h                    |    4 +-
>  arch/avr32/cpu/hsdramc1.h                         |    4 +-
>  arch/avr32/cpu/hsmc3.h                            |    4 +-
>  arch/avr32/cpu/interrupts.c                       |    2 +-
>  arch/avr32/include/asm/arch-at32ap700x/gpio.h     |   10 ++--
>  arch/avr32/include/asm/arch-at32ap700x/hardware.h |   76 ++++++++++----------
>  arch/avr32/include/asm/arch-at32ap700x/portmux.h  |   10 ++--
>  arch/avr32/include/asm/hmatrix-common.h           |    2 +-
>  board/atmel/atngw100/atngw100.c                   |    4 +-
>  board/atmel/atstk1000/atstk1000.c                 |    4 +-
>  board/earthlcd/favr-32-ezkit/favr-32-ezkit.c      |    2 +-
>  board/mimc/mimc200/mimc200.c                      |    4 +-
>  board/miromico/hammerhead/hammerhead.c            |    2 +-
>  drivers/mmc/atmel_mci.h                           |    4 +-
>  include/configs/atngw100.h                        |    4 +-
>  include/configs/atstk1002.h                       |    6 +-
>  include/configs/atstk1003.h                       |    6 +-
>  include/configs/atstk1004.h                       |    6 +-
>  include/configs/atstk1006.h                       |    6 +-
>  include/configs/favr-32-ezkit.h                   |    6 +-
>  include/configs/hammerhead.h                      |    3 +-
>  include/configs/mimc200.h                         |    4 +-
>  22 files changed, 83 insertions(+), 90 deletions(-)

Has the following issues:

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#210: FILE: arch/avr32/include/asm/hmatrix-common.h:120:
+	(((volatile struct hmatrix_regs *)ATMEL_BASE_HMATRIX)->reg)
[left as it is - since this is only a name change patch]

WARNING: line over 80 characters
#253: FILE: board/earthlcd/favr-32-ezkit/favr-32-ezkit.c:107:
+	return macb_eth_initialize(0, (void *)ATMEL_BASE_MACB0, bi->bi_phy_id[0]);
[manually fixed]

WARNING: line over 80 characters
#280: FILE: board/miromico/hammerhead/hammerhead.c:71:
+	return macb_eth_initialize(0, (void *)ATMEL_BASE_MACB0, bis->bi_phy_id[0]);
[manually fixed]

Applied into u-boot-atmel/next.

Thanks,

Reinhard


More information about the U-Boot mailing list