[U-Boot] [PATCH 2/4] armv7: Add ST-Ericsson u8500 arch
Wolfgang Denk
wd at denx.de
Mon Apr 11 20:04:00 CEST 2011
Dear John Rigby,
In message <1300826419-18632-3-git-send-email-john.rigby at linaro.org> you wrote:
> From: Rabin Vincent <rabin.vincent at stericsson.com>
>
> Signed-off-by: Rabin Vincent <rabin.vincent at stericsson.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier at linaro.org>
> Signed-off-by: John Rigby <john.rigby at linaro.org>
...
> +void arm_pl180_mmci_init(void);
NAK.
Please move all prototype declarations to appropriate header files.
This avoids errors like here - arm_pl180_mmci_init() actually returns
int!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Those who will be able to conquer software will be able to conquer
the world." - Tadahiro Sekimoto, president, NEC Corp.
More information about the U-Boot
mailing list